4092
Comment:
|
8429
|
Deletions are marked like this. | Additions are marked like this. |
Line 7: | Line 7: |
== How do I implement my language ? my tiling ? == There are different places to look at for examples: * sage.categories.examples.languages: two examples of languages. PalindromicLanguages (the language of palindromes) and UniformMonoid (the submonoid of the free monoid on {a,b} that contains as many a as b). * sage.categories.examples.factorial_languages: ??? (need an example, Thierry is on) * sage.monoids.free_monoid: implementation of the free monoid. * sage.combinat.languages.*: where most implementation of languages should go. For shifts and tilings, there is (up to now) almost nothing: * sage.dynamics.symbolic.full_shift: the full shift |
|
Line 15: | Line 26: |
* .shifts: the category of shift A^G where G is almost anything and A is a set called alphabet | * .shifts: the category of shift A^G (where G is a semigroup for which the operation x -> gx is injective for any g in G and A is a set called alphabet) |
Line 18: | Line 29: |
* backward compatibility with the previous version | |
Line 33: | Line 45: |
What do we keep? What categories do we create? | What do we keep? What categories do we create? Do we provide a default _element_constructor_ in the category (if yes, it is highly incompatible with facade)? In a next future we should think about mutability/immutability. |
Line 47: | Line 61: |
2. test all letters and never return True | 2. test all letters and never return True in case of equality |
Line 69: | Line 83: |
== Naming convention / duplication == === Parikh vector, evaluation, abelianization === The name '''abelianization''' is the most generic one. '''Parikh vector''' is standard in word combinatorics. '''Evaluation''' is mainly used in combinatorics. Notice that evaluation is formally a composition, in other words the alphabet should be finite and ordered. === Pattern matching === Algorithms for pattern matching may be optimized in subclasses. Hence, we should pay attention for function of low and high level. Vincent proposes to use the following conventions for low-level routines. As it is questions to implement them in C in a near future, this question is crucial: * ''x.find(y [,start [,end]])'': search the first occurrence of y in x[start:end]. Returns the position of the occurrence or -1 in case of failure. * ''x.rfind(y [,start [,end]])'': search backward the first occurrence of y in x[start:end]. Returns the position of the occurrence or -1 in case of failure (not available for infinite word). * ''x.find_iter(y, [,start [,end]])'': return an iterator over the position of occurences of y in x[start:end]. * ''x.rfind_iter(y, [,start [,end]])'': idem but backward (not available for infinite word). * ''x.find_all(y, [,start [,end]])'': return the list of occurrence of y in x[start:end]. * ''x.count(y [,start [,end]])'': count how many occurences of y there are in x[start:end]. There is also the question of multiple matchings and more generally about regular expressions. The actual implementation of pattern matching uses Boyer-Moore algorithm which needs some precomputation for ''y'': last_position_dict, prefix_function_table, good_suffix_table. All theses precomputations are cached_method of a word which may be memory consuming and not very efficient as the following code actually calls twice the precomputation: {{{ sage: w1 = Word('abbabaabaaababa', alphabet='ab') sage: w2 = Word('abababaaaa', alphabet='ab') sage: w1.find('aa') 5 sage: w2.find('aa') 6 }}} Vincent proposes to move all precomputation in a module dedicated to pattern matching and to '''not''' use caching except if the user want to perform many search of ''y'' in many different ''x''. In which case we should do something like that: {{{ sage: w = Word('ab', alphabet='ab') sage: f = Finder(w) sage: f.match(Word('abbababaababbbbababab', alphabet='ab')) ... }}} === Repetitions and exponents === see also # Actual names * minimal_period * exponent * has_period * period([divide_length]) * order * critical_exponent * primitive_length * is_primitive * primitive * is_overlap The actual method ''crochemore_factorization'' is badly implemented. As far as Vincent understand, the only interest |
|
Line 71: | Line 143: |
which should go in the main trac ticket * words path (currently in sage.combinat.words.paths) which have to be modified to fit with the new implementation |
for #12224: * update factorial langages, with doc and tests: task taken by ThierryMonteil * implement a simple example of factorial languages in sage.categories.example.factorial_languages.py : task taken by ThierryMonteil * think about naming convention. For example, to get the subset of words of length n of a language L, do you prefer L.subset(n=4) or L.subset(length=4): task taken by VincentDelecroix * make a dedicated class for palindromic closures * be sure that the methods in sage.categories.languages.ElementMethods are as minimal as possible * words path (currently in sage.combinat.words.paths) which have to be modified to fit with the new implementation (question: should we do this right now ?) |
Line 74: | Line 151: |
* make difference between finite/infinite/enumerated/ordered alphabet (in particular with respect to the category initialization) | * make difference between finite/infinite/enumerated/ordered alphabet (in particular when the parents are initialized with a specific category) |
Line 76: | Line 153: |
other todos for other tickets | for other tickets: |
Languages and tilings
This page gathers ideas for refactorization of sage.combinat.words and implementation of tilings.
You can subscribe to the associated mailing-list to discuss about this.
How do I implement my language ? my tiling ?
There are different places to look at for examples:
sage.categories.examples.languages: two examples of languages. PalindromicLanguages (the language of palindromes) and UniformMonoid (the submonoid of the free monoid on {a,b} that contains as many a as b).
- sage.categories.examples.factorial_languages: ??? (need an example, Thierry is on)
- sage.monoids.free_monoid: implementation of the free monoid.
- sage.combinat.languages.*: where most implementation of languages should go.
For shifts and tilings, there is (up to now) almost nothing:
- sage.dynamics.symbolic.full_shift: the full shift
Structure
The refactorization of the current code should go in the patch #12224 which is almost done. Up to now the code is a bit dissaminated everywhere in Sage:
- sage.categories: Most of the generic code is contained there.
- .languages: A language is a subset of A^* where A is a set called alphabet. It is naturally graded by N and the grading is called the length.
- .factorial_languages: category of factorial languages (= language stable under taking factors)
.shifts: the category of shift A^G (where G is a semigroup for which the operation x -> gx is injective for any g in G and A is a set called alphabet)
- sage.combinat.words
- data structure for finite and infinite words
- backward compatibility with the previous version
- sage.monoids
- .free_monoid: the free monoid (replaces part of sage.combinat.words.words.Words)
.free_monoid_morphism: (replaces sage.combinat.words.morphism.WordMorphism)
- sage.dynamics.symbolic
- .full_shift: an implementation of the full shift (replaces part of sage.combinat.words.words.Words)
- sage.combinat.languages
- implementation of different languages (balanced, language of a finite word, ...)
- specific data structure (suffix tree/trie, rauzy graph, return tree, ...)
What is bad/nice with categories:
- inheritance of generic code
- a bit confusing for the user who want to find the implementation of a method
- confusing for the person who writes the code and ask "where should I put this ?"
- ...
What do we keep? What categories do we create? Do we provide a default _element_constructor_ in the category (if yes, it is highly incompatible with facade)?
In a next future we should think about mutability/immutability.
Behavior of algorithms with infinite input data
What to do for equality of infinite words ?
What should do
sage: w1 == w2
Two possibilities:
- test the first XXX letters for finding a difference. If find one then returns False otherwise raise an error, "seems to be equal use .is_equal(force=True) to launch the infinite test".
- test all letters and never return True in case of equality
Other suggestions ?
Subprojects
Finite languages and factor set
Most of it was implemented by Franco (suffix tree and suffix trie). We would like to enhance it and make a specific data structure (called Rauzy castle) for FiniteFactorialLanguages. See #12225.
Substitutive and adic languages
There are many algorithms for languages described by a sequence of substitutions (called a directive word). The particular case of morphic and purely morphic languages correspond respectively to periodic and purely_periodic directive words.
Enumeration of factors, desubstitution (#12227)
Factor complexity for purely morphic languages (#12231)
- Equality for purely morphic languages (following J. Honkala, CANT, chapter 10)
Eventually periodic languages / words
They will be useful to define eventually periodic directive words for adic languages. See #12228.
Naming convention / duplication
Parikh vector, evaluation, abelianization
The name abelianization is the most generic one. Parikh vector is standard in word combinatorics. Evaluation is mainly used in combinatorics.
Notice that evaluation is formally a composition, in other words the alphabet should be finite and ordered.
Pattern matching
Algorithms for pattern matching may be optimized in subclasses. Hence, we should pay attention for function of low and high level.
Vincent proposes to use the following conventions for low-level routines. As it is questions to implement them in C in a near future, this question is crucial:
x.find(y [,start [,end]]): search the first occurrence of y in x[start:end]. Returns the position of the occurrence or -1 in case of failure.
x.rfind(y [,start [,end]]): search backward the first occurrence of y in x[start:end]. Returns the position of the occurrence or -1 in case of failure (not available for infinite word).
x.find_iter(y, [,start [,end]]): return an iterator over the position of occurences of y in x[start:end].
x.rfind_iter(y, [,start [,end]]): idem but backward (not available for infinite word).
x.find_all(y, [,start [,end]]): return the list of occurrence of y in x[start:end].
x.count(y [,start [,end]]): count how many occurences of y there are in x[start:end].
There is also the question of multiple matchings and more generally about regular expressions.
The actual implementation of pattern matching uses Boyer-Moore algorithm which needs some precomputation for y: last_position_dict, prefix_function_table, good_suffix_table. All theses precomputations are cached_method of a word which may be memory consuming and not very efficient as the following code actually calls twice the precomputation:
sage: w1 = Word('abbabaabaaababa', alphabet='ab') sage: w2 = Word('abababaaaa', alphabet='ab') sage: w1.find('aa') 5 sage: w2.find('aa') 6
Vincent proposes to move all precomputation in a module dedicated to pattern matching and to not use caching except if the user want to perform many search of y in many different x. In which case we should do something like that:
sage: w = Word('ab', alphabet='ab') sage: f = Finder(w) sage: f.match(Word('abbababaababbbbababab', alphabet='ab')) ...
Repetitions and exponents
see also #
Actual names
- minimal_period
- exponent
- has_period
- period([divide_length])
- order
- critical_exponent
- primitive_length
- is_primitive
- primitive
- is_overlap
The actual method crochemore_factorization is badly implemented. As far as Vincent understand, the only interest
TODO list
for #12224:
update factorial langages, with doc and tests: task taken by ThierryMonteil
implement a simple example of factorial languages in sage.categories.example.factorial_languages.py : task taken by ThierryMonteil
think about naming convention. For example, to get the subset of words of length n of a language L, do you prefer L.subset(n=4) or L.subset(length=4): task taken by VincentDelecroix
- make a dedicated class for palindromic closures
be sure that the methods in sage.categories.languages.ElementMethods are as minimal as possible
- words path (currently in sage.combinat.words.paths) which have to be modified to fit with the new implementation (question: should we do this right now ?)
- backward compatibility with the previous implementation (in particular with respect to pickling)
- make difference between finite/infinite/enumerated/ordered alphabet (in particular when the parents are initialized with a specific category)
for other tickets:
- specific data structure rauzy graphs and return tree (Thierry)
- 1-dim subshift of finite type / sofic
- n-dim finite words and n-dimensional shifts
- n-dim subshifts of finite type
- n-dim substitutive subshift
- cellular automata
... add your whishes